Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure verify-godep passes godep to godep-save #36138

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Ensure verify-godep passes godep to godep-save #36138

merged 1 commit into from
Nov 3, 2016

Conversation

saad-ali
Copy link
Member

@saad-ali saad-ali commented Nov 3, 2016 •
edited

Ensure that verify-godeps.sh passes the $GODEP variable to godep-save.sh.

#36111

This change is Reviewable

@saad-ali saad-ali added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 3, 2016
@saad-ali saad-ali self-assigned this Nov 3, 2016
@saad-ali saad-ali merged commit a6bea3d into kubernetes:master Nov 3, 2016
@saad-ali saad-ali mentioned this pull request Nov 3, 2016
Closed
@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2016
saad-ali added a commit that referenced this pull request Nov 4, 2016
@saad-ali
Merge pull request #36203 from saad-ali/automated-cherry-pick-of-#33237-
dfedddf 
#36114-#36132-#36138-#36139-upstream-release-1.4

Automated cherry pick of #33237 #36114 #36132 #36138 #36139 upstream release 1.4
@saad-ali saad-ali mentioned this pull request Nov 9, 2016
Merged
@saad-ali saad-ali deleted the fixGoDeps5 branch November 19, 2016 01:07
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@saad-ali
Merge pull request kubernetes#36203 from saad-ali/automated-cherry-pi…
98ce3fb 
…ck-of-#33237-kubernetes#36114-kubernetes#36132-kubernetes#36138-kubernetes#36139-upstream-release-1.4

Automated cherry pick of kubernetes#33237 kubernetes#36114 kubernetes#36132 kubernetes#36138 kubernetes#36139 upstream release 1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saad-ali @gmarek @googlebot